Steven Luscher
Steven Luscher
Closed by 5a20ed0649fd0fa28d4b6a96ba042c9cdb47630e.
> If someone like QuickNode had a different payload format, they'd need to roll their own JSON RPC… Oh, yeah this would only work for people who implement _actual_ JSON-RPC...
`assertIsFullyButPossiblyBadlySignedTransaction()`
> Both methods will become async functions but I don't think that's an issue. 🪦 https://github.com/microsoft/TypeScript/issues/37681#issuecomment-1650605236
Paul! Thanks for this. This is great, worthwhile work that I'll start on now. I had started down this road in solana-labs/solana#25014 -Â particularly eliminating `@ethersproject/sha2` with a zero-dependency library...
> It also seems like tweetnacl has a security vulnerability… The lockfile for `@solana/web3.js` specifies `[email protected]`. https://github.com/solana-labs/solana/blob/403b2e4841ef7301370e86a443ebe51f8ae512e0/web3.js/yarn.lock#L7345-L7347 Nevertheless, I'll update the deps for avoidance of doubt.
Immediately, when trying to replace `tweetnacl` with `@noble/ed25519`, I fell on my face in exactly the way I expected. All of our signing methods are synchronous, and the Noble library...
> It is the simplest and most reasonable way to implement no-dependency ed25519. 100% agree! > …see how noble-secp256k1 implemented both async and sync versions — it is still possible....
Thanks, @paulmillr!
Closed by 5a20ed0649fd0fa28d4b6a96ba042c9cdb47630e.