Steven Luscher

Results 228 comments of Steven Luscher

Oooh. Interesting point! At minimum, we must point this out in the README (#1911). I love your proxy key solution, but implementing it would pierced the veil of secrecy between...

> The only issue I can foresee is if a user can bypass the polyfill and call the original exportKey function… Yeah, exactly. And so can an attacker, by grabbing...

We've pointed out this limitation in the README (#1911).

Even when I was building this the first time, I considered this just as a tradeoff of memory for performance. There's something that made me uncomfortable about having multiple copies...

I've been noodling on a bunch of concrete ‘ways this could go wrong’ but have yet to get a chance to write them up. Give me a bit to write...

Thanks for this PR @mcintyre94! Of all the other reasons to do something like this (eg. performance) let me rewind way back to the original problem we need to solve:...

> Judging by the image(web3tp.generateKeyPair()), do some types not work as expected? This thing _definitely_ does not work with TypeScript 4.x. I'm trying to upgrade TypeScript in the playground right...

Wow, I'm really glad you know how all this fits together so that I don't have to go figure it all out :) Let me know if there's anything more...

Yeah, for sure difficult. Sorry, I'm just dumb – I can't parse whether “it's probably best if I take care of the types later and save you some time” means:...

> After typing rpc. there is ~1s delay before suggestions show up… 1 second? That's pretty awesome. It [used to be 14](https://github.com/solana-labs/solana-web3.js/pull/1760). In all seriousness, though, presumably it's slower here...