Stepan Koltsov
Stepan Koltsov
In starlark spec starlark, the way to do it is: ``` type(x) == type(1) ``` in starlark-rust we have `isinstance`: ``` isinstance(x, int) ``` which I thing might be helpful...
In our setup we have `native` global, which exposes different attrs depending on the interpreter. When conditional logic is needed, it can be made dependent on the fields and field...
A bit offtopic, but * spec doesn't mention that extension types can override augmented assignment to be done in place, readers might assume that only `list` is special * `*=`...
Such enforcements probably belong to linters, rather than buck2 core. Internally we generally don't use types in bzl files outside of buck2 prelude. Could be a source-level hint recognized by...
@JakobDegen I'm not sure about linters. If this is supposed to be an error, then it should always be an error, not lint. However, I have another possible idea to...
I agree. I think there are two options: * explicitly make features non-exclusive by small copy-paste. This my preferred option. * make two copies of the crate
> would take the union of features and enable the btreemap feature for both Exactly. So if someone relies on it being hash, code will be broken (`Ord` is now...
Can you please add some test that would fail without this PR?
Merged in bdc1428ea745097ea2d12fbc948de80420c77d9d.
It should be bumped tomorrow or so.