stefan-mysten

Results 139 comments of stefan-mysten
trafficstars

> > Is there a reasonable way to test these? > > Not today as there is no easy way of compiling/publishing modules at a different version from the network...

> > When submitting a PR, you can select the "Reviewers" on the right: > > don't seem to have this button.This is what troubles me Ah yes, it seems...

> Some small clean-ups here and there but this is really much nicer than what was there before, thanks @stefan-mysten ! Thanks for all the excellent suggestions! Fixed everything except...

@aravinddojima What do you get when you run: `ls -l /opt/homebrew/opt | grep "postgres"` and `ls -l /opt/homebrew/opt | grep "libp"`

After installing `libpq`, you might need to install `postgresql@16` and then export some directories to your path. ``` brew install postgresql@16 export PATH="/opt/homebrew/opt/postgresql@16/bin:$PATH" export PATH="/opt/homebrew/opt/bin/:$PATH" export LDFLAGS="-L/opt/homebrew/opt/postgresql@16/lib" export CPPFLAGS="-I/opt/homebrew/opt/postgresql@16/include" ```

Thanks @xiaoxianBoy for the contribution and apologies for dropping the ball on this one.

@charlie-bit is this still an issue?

@kklas Thanks for this great work. I promise to look more in-depth a bit later, but regarding testing, the CLI has a bunch of tests that use the `TestClusterBuilder` to...

@kklas we still want to merge this, but sorry we dropped the ball here and thanks for your patience. @hayes-mysten - from testing perspective, anything else you see that's needed?