Sebastian Reichel

Results 8 comments of Sebastian Reichel

Thanks for having a look at it. I will check the things you pointed out next week and also try to figure out a way to split the second patch...

> @sre Is there a link to the patch review on lore for the revised patch slated for 5.19 yet? No, not that I'm aware of.

> So I pulled in most of the preparatory patches, and I adjusted some bits. The major apparmor.c code is still missing. I am working on it. Thanks, the changes...

Hi, I have hit this error (via reqwest) with a server (Zyxel GS1900-10HP switch) response not containing an empty line after the headers: ``` HTTP/1.1 200 OK Date: Tue, 11...

Feel free to drop me a mail. While I do agree that having something working is useful, it is definitely not the same as having something upstream ready. The more...

Ideally the `program`/`read` API stays the same I guess. I have not yet looked into how to implement this best. I noticed that the flashing of 64KiB takes roughly 40...

I gave that a try and it's not enough. Using that with X8 works. For X16/X32 erasing works (and is faster), but `unlocked.program()` fails. Looks like https://github.com/stm32-rs/stm32f4xx-hal/blob/fff9621ad031fbea5b6cdabb1e33a790e9d52bfc/src/flash.rs#L262 needs to write...

I think ideally the `program()` function takes u8 and internally does a 0-3 single byte writes to reach 32 bit alignment, then does 32 bit writes and finally uses 8...