Stavros Korokithakis comments

Results 533 comments of


                                            Stavros Korokithakis

trafficstars

ajax_request decorator - use django json encoder

Hmm, that's an idea, but the new decorator would necessarily be misnamed a bit, so I'm not a huge fan of this practice...

ajax_request decorator - use django json encoder

The extra parameter still breaks backwards compatibility, since it's not called with parameters by default, but I really like the alternative names. Something like `json_response` might be the most fitting,...

ajax_request decorator - use django json encoder

Yeah, you're right. I didn't consider that we'd never be accepting function arguments in normal usage, so I'll go with your proposed fix above. If anyone wants to beat me...

ajax_request decorator - use django json encoder

@mknecht, have you found something that the default json module will serialize but Django's JSON encoder won't? Decimals do stay a string, but the default JSON encoder produces an exception,...

ajax_request decorator - use django json encoder

That's odd, I've been using it for proper serialization of dates and it's worked fine. I'll investigate.

ajax_request decorator - use django json encoder

Certainly, PRs are welcome. I am a bit swamped right now :/

Using AutoOneToOneField with proxy model

Thanks for this research! Unfortunately, I've never used the `AutoOneToOne` model myself, so you know more than me at this point. Would you like to submit a PR with the...

Fix translations in wheel files, build translations on build, remove .mo files

This seems reasonable to me, does it work well for you? If so, I will merge it now and wait a bit for any problems to be reported.

Send user_id with POST

Ah, yes, that's a good idea. Would you like to submit a PR that will accept both?

Add documentation for usage in templates

This is useful, could you file a PR? I haven't touched the template code in a while.