Sigurd Spieckermann

Results 255 comments of Sigurd Spieckermann
trafficstars

I'm not sure what to do about the type error. 🤔 Any advice?

I think the problem is caused by `@types/jest-when`: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/68605#issue-2130731211

Okay, I noticed that [`jest-mock-extended` also has a `calledWith()` extension](https://github.com/marchaos/jest-mock-extended?tab=readme-ov-file#calledwith-extension), so I'll try to modify the tests to use it instead.

Thanks for the thorough and valuable feedback, @viceice! :bow: I've addressed your remarks. WDYT? :slightly_smiling_face:

I didn't force-push to rebase onto the latest state of `main` but only amended and force-pushed the most recent commit before your subsequent review because it caused the CI pipeline...

I've merged `main` into here and fixed the temporary directory path like in https://github.com/renovatebot/renovate/commit/1f0ce9abcde5ff90bea2d6e21633d8159d49b597. WDYT, @viceice?

It's a bug indeed. :bow: See https://github.com/renovatebot/renovate/discussions/30999#discussioncomment-10442102 and #31005.

I don't think the tests need fixing because they were passing for f335126f0bf16624e469b34e3df3f959161c2f8a and the current state of this PR should be only a refactoring, but now some tests are...

@viceice You're exactly right, the mocked function caused the tests to fail. :+1: Before, the line ```ts config = { ...config, ...(await shouldReuseExistingBranch(config)) }; ``` was effectively ```ts config =...

This happens only when `-A, --skip-answered` is passed as well. The reason is that a new answer is not _parsed_ when `-A, --skip-answered` is passed and the question has a...