Sigurd Spieckermann

Results 258 comments of Sigurd Spieckermann
trafficstars

@retr0h Old tools but widely adopted. There's nothing wrong with that. Anyway, how would you implement the code that downloads the binaries for the given platform and architecture during package...

I don't think any of the errors were introduced by this PR.

I've rebased this PR onto the latest state of the `3.1.x` branch. All tests are passing except `pre-commit.ci - pr`, but the reported errors originate from `3.1.x` and weren't introduced...

I was implicitly mapping `scheme -> vega_theme` and `scheme_dark -> vega_theme_dark` where `scheme`/`scheme_dark` are Material for MkDocs theme names, whereas you're suggesting an explicit Vega theme selection (or auto-detection) via...

Absolutely! Sorry, I had forgotten about it. I'll finish it tomorrow evening.

I've updated the PR to add explicit `mkdocs-material` integration and also user's preferred color scheme detection as discussed above. I split the two changes into separate commits to separate concerns....

Fantastic! Thanks for the amazing feedback and guidance! :pray:

I've been wondering about all these questions myself and haven't found a satisfying answer yet. @mattlbeck Wouldn't `dvc push --run-cache` pollute the DVC remote storage? The amount of run-cache data...

There's a subtle difference between using `_exclude` and Jinja conditions in directory/file names: `_exclude` refers to _generated_ directories/files, so it may be difficult/unintuitive/verbose to come up with a correct pattern...

Thanks for the thorough analysis and report of this problem, @ink-splatters! :pray: Besides fixing the file, should we set this Git configuration you show above (without `--global`) in the Nix...