silverwind

Results 1283 comments of silverwind

Exactly, after #358, `include_file` will work, regardless whether the extension is in `include_ext` or not.

Does it also work when `cmd` and `full_bin` run? Please add some docs on where it exactly applies. I guess some people might also prefer a separate vars file between...

Also seeing that error with certain big packages like `eslint-config-hardcore`, which is [177MB](https://pkg-size.dev/eslint-config-hardcore).

Isn't this already supported as per https://github.com/vectordotdev/vector/pull/19342 and https://vector.dev/docs/reference/configuration/sinks/kafka/#encoding.avro? Why is the issue still open?

My conclusion is that standard Avro encoding is supported on the Kafka sink, but the proprietary [Confluence Schema Registry wire format](https://docs.confluent.io/cloud/current/sr/fundamentals/serdes-develop/index.html#wire-format) is not, see https://github.com/vectordotdev/vector/issues/19872 for that topic. Likely enough...

Noticed this too. At first I thought it could be some race, but it seems to not matter when `setCompilerOptions` is called, before or after editor creation, it will always...

Actually I found the problem: One is likely supposed to not replace all options, but merge into the existing options: ```js monaco.languages.typescript.typescriptDefaults.setCompilerOptions(Object.assign( monaco.languages.typescript.typescriptDefaults.getCompilerOptions(), compilerOptions, )); ```

It's a failed heuristic. The idea behind router-ips is to detect cases where routers intercept HTTP requests, like captive portals for example. I think we better remove most IPv4's in...

I guess I would be in favor of just removing `router-ips` here. Guess it's better to just suceed a reachability check if there is something on the remote end, even...

There is now https://github.com/sindresorhus/is-network-error, a bandaid solution that matches on the returned error strings, which all implementations handle differently. This is probably not easily fixable from a spec perspective because...