gitea
gitea copied to clipboard
Replace fomantic popup module with tippy.js
WIP with various errors still left to resolve, cleanups to be done. Regular tooltips work.
This is ready in the sense that it doesn't throw JS errors anymore.
What remains to be done:
- Check if all JS features work.
- Maybe restrict certain tooltips in width.
Of note: The code line menu is now a proper menu and it also closes after copy permalink:
Would be nice to make it accessible using aria attributes
Would be nice to make it accessible using aria attributes
It already sets the tooltip and menu roles on the tippy instances. What else do you have in mind? Some attributes on the trigger element as well?
Edit: aria-describedby might be possible. Edit2: aria-describedby and aria-expanded is already handled automatically.
Still a few things untested:
- commit status popup
- stopwatch popup
- tooltip widths
This should be ready to review/merge. At least I don't find any more issues.
@go-gitea/maintainers need one more review for the refactoring, to avoid potential conflicts in the future.
popup bug:

And here (commit history) it seems better to make the popup shown on the ~~right~~ top or bottom.

Ah, I may have missed that popup, checking.
https://github.com/go-gitea/gitea/pull/20736 to fix this popover.
And here (commit history) it seems better to make the popup shown on the ~right~ top or bottom.
I tend to agree that top/bottom is probably a better positioning then left/right for this popover.
I have applied https://github.com/go-gitea/gitea/pull/20736 but the popup still shows [object Text]
And it's not related to the hide CSS class.


https://github.com/go-gitea/gitea/pull/20737 is the actual fix, I split up that PR.