silverwind

Results 1225 comments of silverwind
trafficstars

Another case: https://github.com/go-gitea/gitea/pull/29106#issuecomment-1935299040 This is what I did locally and it worked fine: ```bash git checkout release/v1.21 git reset --hard origin/release/v1.21 git checkout -b backport-29106-29111 git cherry-pick 9c39f85 git cherry-pick...

I think the bot currently can not successfully do any backport onto `release/v1.21`. I assume once we cut `release/v1.22` it will be able to again for unknown reason. I think...

So I think I will write a new backport script in bash, commit it to repo and we let the bot use it. Much easier to debug than running the...

I think https://github.com/vitest-dev/vitest/pull/3998 is likely the culprit. Something about the `Uint8Array` returned by `TextEncoder` makes it fail, even thought those values are definitely structurally equal.

The cause is [this removal](https://github.com/vitest-dev/vitest/pull/3998/files#diff-af862ead1f0516f5c67aa19607c6baffe9c85cc2368b762d975a280503cd0d2bL72), specifically: `TextEncoder` (and `TextDecoder`) is a Node API and `Uint8Array` is a jsdom API. The `Uint8Array` that both produce are not comparable, even while structurally...

Config is pretty much [default configuration](https://github.com/go-gitea/gitea/blob/main/vitest.config.js). `TextEncoder` is [global](https://nodejs.org/api/globals.html#textencoder) in node since v11, so unless vitest deletes these globals (maybe it should), they will be present in non-node environments. I've...

> We have es-module-lexer that works for ESM and cjs-module-lexer for CommonJS. But we still need lexers for JSX / TypeScript / TSX (or even flow). I still want TypeScript...

I think I'll be using `actions/cache` directly to have full control over that cache, but other users might be interested in such an option.

Not sure if it's the same issue, but I noticed this problem in build 4169 or earlier on Mac: - Select some text in the editor - Hit Cmd-F (search)...

> Fixed in build 4170. Thanks. It looks like that fix also resolved https://github.com/sublimehq/sublime_text/issues/6194#issuecomment-1935787298 for me.