Brendan Forster

Results 572 comments of Brendan Forster
trafficstars

I put together this test to see the behaviour for myself: ```c# for (int i = 0; i < 12; i++) { int k = i + 1; var newLabel...

Currently there are three areas where timeouts can be changed: - `GitHubClient.SetRequestTimeout` to set the timeout globally ```c# var client = new GitHubClient(new Connection(new ProductHeaderValue("OctokitTests"))); client.SetRequestTimeout(TimeSpan.FromSeconds(15)); ``` - `IRequest.Timeout` is...

@arxange1 isn't 1) the global timeout and 2) the per-request timeout?

> To get a right answer we have to define what the global timeout is. I don't quite understand, but I want to focus on what Octokit **should** be doing,...

@arxange1 correct - at the time we didn't want to make users really think about that, which is why we provided those specific overloads as well as the global `GitHubClient.SetRequestTimeout`.

Marking this one as a bug, but because there's a workaround and plenty of other work I'm not sure when we'll get to it.

@Eilon thanks for the report and the snippet - I've been able to get this into a integration test and see the behaviour for myself. This is down to the...

@SCLD-BugBot can you share a full snippet of what you're trying to achieve?

> Is there some other permission they need to be able to do this? From [the docs](https://developer.github.com/v3/issues/#create-an-issue): > Labels to associate with this issue. _NOTE: Only users with push access...

> This call doesn't return any data when using the OAuth token returned, but if I hard-code a PAT and run it, I get all my orgs back. This suggests...