Brendan Forster

Results 600 comments of Brendan Forster
trafficstars

> The username@ should work with GitHub, because there's no reason it should not - but there is also no guarantee (unless @shiftkey or @Haacked wants to make one 😉)....

@kentcb I haven't kept up with this project for a while, but I wanted to point out a clue from the logs. Note the `'https://github.com/'` URL used here to look...

This requires two things: - registering GCM as an OAuth app which the user verifies - registering GCM as a protocol handler on install so that it can handle the...

I'm pretty sure this was something I was tracking as part of auditing everything in https://github.com/octokit/octokit.net/pull/1038/ but I'd need to remember just what past me was doing there...

@jaredpar yeah, silly 1-based pagination 😞 - let me know if there's any way we can make this clearer. If you drop the pagination overload the GitHub API will return...

An example PR where we've had to fix this in the past: https://github.com/octokit/octokit.net/pull/1703 Happy to push out a release asap about it if you have a fix.

@patriksvensson got a sample script that helps us to know where it's overflowing?

Release titles are chosen mostly at random. I endorse this name for the one that fixes this.

> Maybe our clients need to return response objects and not just the actual entities I think that's the best place to put this data. It kinda sucks, but a...

Fun fact: we currently have this `IApiRespose` type which captures the relevant fields to do this: ``` csharp public interface IApiResponse { T Body { get; } IResponse HttpResponse {...