Andrew Powell
Andrew Powell
@himanshuchawla009 please do not post "me too," "+1" type replies. They spam anyone who has notifications on for issues (e.g. all maintainers). Please use the reaction buttons on the original...
I generally don't have much stake in this plugin. Please check out the history and which maintainers have contributed to it in the past for their feedback.
Since the other two maintainers are quiet at the moment, I'll chime in to try and get this moving forward. I generally don't like to merge breaking changes unless there's...
@NikkiTheBugSlayer if you don't see activity in this issue, then there has been no activity.
I'm in favor of the change, but having to manually maintain two separate type files is additional burden on an already lean squad of maintainers. I'd like to see this...
This PR hasn't seen any activity in over 60 days now. Because it's already been reviewed, I'd really rather not close it as abandoned. My concern about two separate type...
Thanks for the PR! You're on the right path, but just off of it. I think the idea is good for default behavior as well, and while it is breaking,...
CI is failing due to a TypeScript issue in another plugin. I'll resolve that on Monday
OK so your change here: https://github.com/rollup/plugins/pull/1170/files#diff-0fba79f6114491dd08bed97b1b30652eadf2b4494f41b699f85889a579c1e422L36 caused this TS error here: https://github.com/rollup/plugins/runs/8287319672?check_suite_focus=true#step:7:260 Please fix that error, be sure to run `pnpm lint` and `pnpm build`
> I could fix the conflicts but I'll need someone to merge it @perrin4869 please do, then ping me directly if you don't see action within 24 hours.