plugins icon indicating copy to clipboard operation
plugins copied to clipboard
verified publisher icon rollup

fix(run): compatability with `commonjs` plugin

Open koistya opened this issue 3 years ago • 4 comments

Rollup Plugin Name: run

This PR contains:

  • [x] bugfix
  • [ ] feature
  • [ ] refactor
  • [ ] documentation
  • [ ] other

Are tests included?

  • [ ] yes (bugfixes and features will not be merged without tests)
  • [x] no

Breaking Changes?

  • [ ] yes (breaking changes will not be merged unless absolutely necessary)
  • [x] no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

The facadeModuleId variable includes ?commonjs suffix breaking chank.facadeModuleId === input

koistya avatar Apr 25 '22 11:04 koistya

@lukastaegert just updated the PR with your suggestion

koistya avatar May 22 '22 11:05 koistya

@shellscape pushed

koistya avatar Sep 10 '22 20:09 koistya

CI is failing due to a TypeScript issue in another plugin. I'll resolve that on Monday

shellscape avatar Sep 10 '22 20:09 shellscape

OK so your change here: https://github.com/rollup/plugins/pull/1170/files#diff-0fba79f6114491dd08bed97b1b30652eadf2b4494f41b699f85889a579c1e422L36 caused this TS error here: https://github.com/rollup/plugins/runs/8287319672?check_suite_focus=true#step:7:260

Please fix that error, be sure to run pnpm lint and pnpm build

shellscape avatar Sep 12 '22 13:09 shellscape

~~not sure why CI isn't running on your PR. I'm afraid you'll need another force push.~~ figured out I could kick CI with a change to the PR title

shellscape avatar Oct 24 '22 17:10 shellscape

A failing tests there: https://github.com/rollup/plugins/actions/runs/3314957482/jobs/5474917583#step:11:35

shellscape avatar Oct 24 '22 17:10 shellscape

Closing as abandoned.

shellscape avatar Jan 06 '23 15:01 shellscape