shashank khare

Results 42 comments of shashank khare
trafficstars

@rajvijay68 can you fix the conflict, will merge.

Thanks for the PR, but can you insert the link to the actual landing page of the author for this book? I think hosting a pdf directly might be a...

Will add a flag for lenient mode and fail the write otherwise

I set it up on my laptop, tested out the pre-commit hook - works pretty well. Didn't seem to be breaking any tests as far as I can see. The...

The change is on my laptop right now, will push it to a branch at night so you guys can see how it looks. @bmoscon Black is interesting in this...

https://github.com/shashank88/arctic/commit/e8d19edcb8699a1c62776fd5a471feba19bb373b is with the default autoformatting (88 line limit)

* So the first thing can be easily addressed by setting the black limit-limit to 110. The reasoning they give for 88 is here: https://github.com/ambv/black#line-length .I can change the limit...

@bmoscon Do you think it's worth me resending a PR with 110 line limit? Happy to close this if you are not pro this change

@yschimke @bmoscon here is a PR with 110 line length: https://github.com/manahl/arctic/pull/769 Need to clean up commits etc. but this is just to get a rough diea