Sam Gammon

Results 356 comments of Sam Gammon

@holzensp You are totally right! The intent is **not** to merge this PR, but instead to offer a menu of changes for the Pkl team from our fork. I am...

Okay, I will pause there for now because I'm not sure which of these other changes you guys would like to see filed. Liking comments from the self-tour is a...

@holzensp I have re-requested review with a new batch of changes, with another self-review listed above. This gets into bigger refactors like `buildSrc` → `build-logic`, JPMS, and GraalVM → `23.x`,...

@holzensp No problem! Take your time and hope your trip off-grid was good 😁. There's a lot here, this fork is alive and continues to evolve. The latest summary of...

@CommanderTvis thank you for the quick review, sorry for the mess 😅 we are trying this downstream to see if it works as expected.

With regard to the `NoSuchMethodError`, here is the exception silenced by that code: ``` java.lang.NoSuchMethodError: 'void com.intellij.openapi.util.io.NioFiles.deleteRecursively(java.nio.file.Path)' at org.jetbrains.kotlin.test.services.impl.TemporaryDirectoryManagerImpl.cleanupTemporaryDirectories(TemporaryDirectoryManagerImpl.kt:45) at org.jetbrains.kotlin.test.TestRunner.runTest(TestRunner.kt:32) ``` I remember now. This `deleteRecursively` function on `com.intellij.openapi.util.io.NioFiles`...

@Jeffail understood and that should be fine, consider this paused :) feel free to ping when I should proceed. We're in no rush.

@Jeffail awesome, thx for ping!

@faisal00813 This code was contributed when this project was Benthos. I no longer wish to contribute, sorry!

@sandwwraith We just ran into this on latest (`1.6.3` / `2.0.0-Beta4` as of this writing), and we are not using any custom transformers. Output example: ``` "conventions": { "@class": "kotlin.collections.LinkedHashMap",...