Sam Gammon
Sam Gammon
Second the suggestion for this; we _do_ have an `on.push` hook, but the CodeQL workflow can't find it, because it is buried in a reusable workflow (which is a best...
@aeisenberg we are pinned to `v3`, with no hash, so i would guess that we are already on that version or greater: ```yaml - name: "Analysis: CodeQL (Language: ${{ inputs.language...
@aeisenberg It has a `workflow_call` trigger _only_, because we _always_ handle `pull_request` and `push` hooks in an "outer" entrypoint job, and then dispatch actual jobs with reusable workflows.
@aeisenberg I'm really not sure either, because you're right, I would expect the warning from that run. The repos where we are still seeing the warning are all private, and...
Hey @bioball, sorry I missed your review here! I'll take a look. The problem with sealed classes is a bigger issue that may need some design attention before this feature...
@meisterT I actually do still need it downstream in [`rules_graalvm`](https://github.com/sgammon/rules_graalvm). It would be great if this could eventually be merged.
In this (very specific) case, the [GraalVM rules](https://github.com/sgammon/rules_graalvm) may be [compiling a Java binary to a native image](https://www.graalvm.org/latest/reference-manual/native-image/), and it may notice via Bazel's [flags](https://docs.bazel.build/versions/4.0.0/skylark/lib/configuration.html#coverage_enabled) that coverage instrumentation has been...
@fmeum Yes, that may work and would be a better approach. I hadn't seen that, I'll give it a try. Thanks for the pointer
Some screenshots for your viewing pleasure: **New project icon in IDEA** **Highlighting of Pkl with language injections** **New Github Action jobs for PR checks** **Mocha-style test logging for clear testing...
I intend to benchmark this against `main` (the build, and runtime) to make sure it is an actual improvement over the status quo. I'll update this comment with the results...