Tim Bannister
Tim Bannister
@sreeram-venkitesh there's pending feedback; would you be willing to revise this PR based on that feedback?
Even if we change the behaviour here, it's good to document the current behavior and get that detail merged first. That way, it's on record for older docs versions.
Changelog suggestion (early feedback) ```diff -kube-controller-manager adds a new controller named volumeattributesclass-protection-controller which adds/removes finalizer to VAC for protection. +Added a new controller, volumeattributesclass-protection-controller, into the kube-controller-manager. +The new controller...
I like the idea of annotating the CronJob's timings into the Job and its Pods: - the actual creation timestamp of the Job - create a [suspended](https://kubernetes.io/docs/concepts/workloads/controllers/job/#suspending-a-job) Job - capture...
I guess one thing to note is that (IIRC) you can't implement the equivalent out of tree, because: - at admission time, `metadata.creationTimestamp` isn't set, so a mutating admission controller...
/sig architecture