website icon indicating copy to clipboard operation
website copied to clipboard

KEP 4960: Container Stop Signals

Open sreeram-venkitesh opened this issue 9 months ago • 6 comments
trafficstars

Description

Docs for KEP 4960: Container Stop Signals.

Related PRs

  • Enhancements PR: https://github.com/kubernetes/enhancements/pull/5122

Issue

Closes: nil, part of https://github.com/kubernetes/enhancements/issues/4960

sreeram-venkitesh avatar Feb 21 '25 18:02 sreeram-venkitesh

Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
Latest commit ba588e909725f8ce33aa036a377a4f931c0ffe39
Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f46e36e8d4c6000868baa9

netlify[bot] avatar Feb 21 '25 18:02 netlify[bot]

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit 5ae90290e27b10a0f8ff9b4b459f97718635746b
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67b8c97812e525000814ccb1
Deploy Preview https://deploy-preview-49857--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 21 '25 18:02 netlify[bot]

Pull request preview available for checking

Name Link
Latest commit ba588e909725f8ce33aa036a377a4f931c0ffe39
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f46e3683db830008800321
Deploy Preview https://deploy-preview-49857--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 21 '25 19:02 netlify[bot]

The route I recommend is (still):

…add a new detail within https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination

Mention that even if you don't specify a stop signal within the Pod manifest:

  • the container runtime attempts to signal graceful termination

  • the signalling mechanism is OS-dependent

and then, do mention that you can customise the signal for Linux Pods, by adding a StopSignal entry within lifecycle:

sftim avatar Mar 28 '25 09:03 sftim

@sreeram-venkitesh there's pending feedback; would you be willing to revise this PR based on that feedback?

sftim avatar Mar 28 '25 09:03 sftim

@sftim @lmktfy Please take a look if the changes are in the right direction. The docs itself might need more wordsmithing.

sreeram-venkitesh avatar Mar 29 '25 11:03 sreeram-venkitesh

Hello @sreeram-venkitesh , :wave:! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

Urvashi0109 avatar Apr 03 '25 11:04 Urvashi0109

/approve

tengqm avatar Apr 08 '25 00:04 tengqm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 08 '25 00:04 k8s-ci-robot

@haircommander This PR could use an lgtm. Thanks!

rayandas avatar Apr 08 '25 06:04 rayandas

/lgtm

haircommander avatar Apr 08 '25 07:04 haircommander

LGTM label has been added.

Git tree hash: 0212666afb3101ef1994e5b0e9f4551176a0b1a9

k8s-ci-robot avatar Apr 08 '25 07:04 k8s-ci-robot