Tim Bannister

I looked at https://github.com/kubernetes/kubernetes/pull/112981 and I'm concerned. I saw several places where the API is defining not just lists of node names, but also limits on how many items can...

This enhancement proposal mentions the annotation `snapshot.storage.kubernetes.io/allowVolumeModeChange`. Would it be possible to deprecate that in favor of a more conventional `snapshot.storage.kubernetes.io/allow-volume-mode-change`?

/retitle KEP 1710: Update SELinux mount ReadWriteOnce optimization for 1.26

If this was implemented for v1.23, did we already update docs accordingly?

/lgtm

I think I've spotted a design defect. https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2268-non-graceful-shutdown suggests using the private `out-of-service` taint; however, private taints are reserved for cluster operators and Kubernetes should not infer a specific meaning...

I mentioned the same concern in https://github.com/kubernetes/kubernetes/pull/108486#discussion_r819752216

I have a query: how is this different from the built-in `cpu` resource? Linux blockio lets you configure controls such as `blkio.throttle.read_bps_device` and similarly, for CPU you can define requests...

To clarify why I think blkio is vendor-specific: only Linux nodes have this resource. Windows nodes have CPU and memory but they don't have blkio or a direct equivalent. I'd...

The update should _usually_ happen within a few hours.