enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP 1710: Update SELinux mount ReadWriteOnce optimization for 1.26

Open jsafrane opened this issue 3 years ago • 7 comments
trafficstars

Update "Speed up recursive SELinux label change" for Kubernetes 1.26

  • Issue link: #1710

  • Updated the checkboxes at the beginning with the current state.

  • Added metrics.

  • Added details about volume reconstruction refactoring.

The feature stays in alpha in 1.26.

jsafrane avatar Sep 26 '22 09:09 jsafrane

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 26 '22 09:09 k8s-ci-robot

Not sure if it's needed, the feature was alpha in 1.25 and stays so in 1.26 /label lead-opted-in

jsafrane avatar Sep 26 '22 10:09 jsafrane

/retitle KEP 1710: Update SELinux mount ReadWriteOnce optimization for 1.26

sftim avatar Oct 10 '22 17:10 sftim

/assign @gnufied @jingxu97 to review reconstruction design changes

msau42 avatar Oct 26 '22 23:10 msau42

I am linking all volume reconstruction PRs to this enhancement update - I am trying to make as small and independent PRs as possible.

jsafrane avatar Oct 27 '22 16:10 jsafrane

I know we're changing this as part of the SELinux work but I wonder if it's worth having a separate doc just for reconstruction in general. There are other issues that would be great to fix such as reconstructing global mounts, and supporting non-mounting csi drivers.

msau42 avatar Oct 27 '22 20:10 msau42

separate doc just for reconstruction in general

That sounds good. Where the document should be? We still have https://github.com/kubernetes/community/tree/master/contributors/devel/sig-storage, but IMO it's not a good place.

jsafrane avatar Oct 31 '22 12:10 jsafrane

separate doc just for reconstruction in general

I opened https://github.com/kubernetes/enhancements/pull/3763

jsafrane avatar Jan 27 '23 12:01 jsafrane

/close in favor of https://github.com/kubernetes/enhancements/pull/3797

jsafrane avatar Jan 30 '23 17:01 jsafrane

@jsafrane: Closed this PR.

In response to this:

/close in favor of https://github.com/kubernetes/enhancements/pull/3797

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 30 '23 17:01 k8s-ci-robot