Shane F. Carr
Shane F. Carr
Another solution I'm open to considering is to have the macro generate `#[doc(hidden)]`, in addition to the internal warning, and then when generating internal docs use `--document-private-items` which includes doc(hidden)...
@Manishearth's proposal SGTM. Either way I would like a macro so that it's easy to find and tweak over time.
Very cool! It makes me hungry for some oatmeal though! 😋 As far as the site content goes, we have 4 sets of docs, all of which are generated with...
Note: Although there are about 30 files added, almost all of them are sample content that we can delete or replace with our own content. There is not a lot...
Specifically, the cfg should be set on the job that creates the docs uploaded to https://unicode-org.github.io/icu4x/rustdoc/, and the "unstable feature" box should be included so that people referencing those docs...
Open question: where should the internal docs macro live? I propose it lives in a macros file that we copy around the repo into each crate and have a CI...
What are the pros and cons of hosting in the main repo versus icu4x-docs?
Symlinks are [annoying](https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows) for Windows users, but it appears there are [solutions](https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows/59761201#59761201) that require some manual setup. I tend to feel that in order of priority of constituencies, the experience...
The removal of the generated files you reference was done after establishing that doing so didn't substantially impact other constituencies.
The existing symlink impacts diplomat-gen, which impacts all contributors but not clients. The proposed symlink would impact _anyone_ building icu4x from the repo.