Shane F. Carr comments

Results 2006 comments of


                                            Shane F. Carr

`icu::timezone` but `icu::datetime::time_zone`

We decided "Metazone" is one word but "Time Zone" is two words (https://github.com/unicode-org/icu4x/issues/2507). This implies that it should be `icu::time_zone`. But, that is a crate name. Options: 0. Live with...

`icu::timezone` but `icu::datetime::time_zone`

Discuss with: - @leftmostcat - @sffc - @robertbastian

`icu::timezone` but `icu::datetime::time_zone`

CC @markusicu

`icu::timezone` but `icu::datetime::time_zone`

I maybe prefer option 3 just because TimeZone stylized with that casing is so common. But it means camel and snake don't agree which is unfortunate.

`icu::timezone` but `icu::datetime::time_zone`

Ballots: https://docs.google.com/document/d/1cwObpQ_gdCsoZVEDNV7C-7eODxElGIJ3FNdivlbLnNo/edit Results: Options 0, 1, and 4 have vetoes. Among 2 and 3, option 2 is much more popular. It is also the first choice of 6 of 7...

`icu::timezone` but `icu::datetime::time_zone`

The winning option 2 is the following style: - Module and crate names: `timezone` (flat case) - Function names, type names: camel or snake case depending on language conventions

Support adjusting break iterator position by an offset

@eggrobin has some thoughts on this.

Support adjusting break iterator position by an offset

This month @anba landed Intl.Segmenter in Firefox based on the ICU4X Segmenter impl, reviewed by @dminor https://phabricator.services.mozilla.com/D195803 I had been under the impression that Intl.Segmenter was not implementable without support...

Always use discriminant marker in ZeroTrie serialized form

Discuss with: - @robertbastian - @sffc Optional: - @Manishearth

Always use discriminant marker in ZeroTrie serialized form

Resolution: OK to do this if it impacts only Serde and is reasonably backwards compatible.