Shane F. Carr

Results 1769 comments of Shane F. Carr

It's a zerovec concern to create `ZeroVec`. We could have just had `Cow`. It's a zerovec concern to create `VarZeroVec`. We could have just had `Cow`. I think it is...

About stack size: what I was thinking (the reason I said "might") is that there are some various ways of various levels of desirability that we could get an extra...

> I think this issue is proposing adding a type to zerovec to work around a serde concern. I used to think this, but my thinking shifted when I thought...

I think I understand your position, and I think we differ one some fundamentals and experiences. More on that later. To break down that middle paragraph: > Basically: I see...

Would you agree that the following would be in scope for the `zerovec` crate: a standalone tutorial module showing people how to put `zerovec` types into a data struct for...

About `ToOwned`: We don't need `ToOwned`, because `VarULE` gives us everything we need. We can get a byte slice, allocate it, and cast it back. That's something `ToOwned` can't do....

I'm trying to break down where we disagree. ## Fundamentals ### Fundamental: The bar for adding things to `zerovec` Maybe we don't agree on the cost of adding abstractions to...

> If you do all of this correctly, and add a ToOwned impl, _then_ `Cow

Thought: ZeroCow could have a type parameter that configures the human readable serialization, and it defaults to something that serializes it as a sequence of bytes. Alternatively, it could reference...

Currently one needs to set the currency or unit in the constructor of `Intl.NumberFormat`, and the `.format()` function takes only the number. The ask is for the unit and currency...