Shane F. Carr comments

Results 1809 comments of


                                            Shane F. Carr

Design how we want to resolve preferences

Putting in 2.0-stretch in case we want to change anything. (A likely conclusion is that "status quo is fine")

Design how we want to resolve preferences

- @sffc Should we try to centralize this logic in `icu_locale`? It's what I originally had in mind early in the project. - @Manishearth I don't see much value in...

ZonedDateTime parse functions are a pain to use

Maybe this is being caused by the `Z`.

ZonedDateTime parse functions are a pain to use

CC @nekevss

ZonedDateTime parse functions are a pain to use

The change i want to implement is a 5-line change to make the string in the OP work correctly.

ZonedDateTime parse functions are a pain to use

I realized that I think the problem is that we unconditionally treat `Z` as "requires calculation", even if the time zone is `Etc/GMT` or `Etc/UTC`. My proposal is to allow...

Changing baked data to use zerotrie

Have you measured impact on binary size and performance?

Changing baked data to use zerotrie

While I think we should explore this, there are some factors at play that might make ZeroTrie less compelling for baked data than for blob data: 1. The compiler is...

Changing baked data to use zerotrie

Do you have metrics?

Changing baked data to use zerotrie

I'm sorry, can you help me know which commits to review and which commits are datagen only? If I omit just the last commit entitled "gen", I still get a...