Serge Shustov

Results 19 comments of Serge Shustov

Could you please at least add a button somewhere in the preview window to refresh it manually? Sometimes it requires some scrolling to find the preview button and refresh after...

UPD: seems to work fine with `executionStrategy = new com.malinskiy.marathon.config.strategy.ExecutionStrategyConfiguration(com.malinskiy.marathon.config.strategy.ExecutionMode.ALL_SUCCESS, true)`. Maybe add it to countSharding doc?

Well, it's a new thing that wasn't there before 0.8.x, it's not that easy to find in documentation (or maybe I'm just dumb) and countSharding doesn't work with default executionStrategy,...

@Malinskiy in some cases yes. But if there is a significant number of failures, a limited number of devices and failures sometimes caused by test BE short shutdowns or something...

TODO: - [x] make sure injected function is a top level function ~~or belongs to global object (or make sure it's called correctly with the receiver provided)~~ - [x] make...

Ok, I'll remove dagger's assisted factory annotation too. What do you think of non-sam interfaces for assisted factories though? Without an easy migration from dagger in mind it might not...

Ready for review. I don't quite like how it turned out with findAssistedFactoryFunction and findAssistedFactoryInjectFunction functions, and how potential name shadowing is handled... But for now I have no idea...

Decided to go with a single `@AssistedFactory(injectFunction = "optional.function")` and a single function allowed in assisted factory. With multiple functions the injectFunciton name would have to go to a separate...

@evant is there something we need to do to merge this? To me a few files look a bit bloated, but I wouldn't want to mess up the history by...

@Monabr I don't think I have write access to do that