Selwin Ong

Results 507 comments of Selwin Ong
trafficstars

I’m hoping to release 2.x by end of March.On Feb 21, 2024, at 8:14 AM, Ethan Wolinsky ***@***.***> wrote: @selwin thanks will try to address by the end of this...

Hopefully last round of review. No logic or new features, just minor nitpicky details! Thanks!

I haven't seen this error before. Can you elaborate on how to reproduce this?

RQ does not support Redis cluster yet. PR ti fix this welcome :)

@kuwv I'm ok with merging this in. Do you mind taking a look at whether you can increase the coverage for this set of changes?

I'm closing this PR for now. Please reopen if you're still interested in merging this in. Thanks!

I'm closing this PR for now. Please reopen if you're still interested in merging this in. Thanks!

Is it possible to setup a Redis cluster to test this in CI?

Ok great. Do you mind adding Redis cluster to the test matrix then? I think we can just test it with the latest Python and redis-py version.

@MykolaBordakov I don't think need separate tests for Redis Cluster. The important thing is making sure that existing tests run on Redis cluster. So what you need to figure out...