Selwin Ong comments

Results 508 comments of


                                            Selwin Ong

trafficstars

Use RedisCluster as connection argument for rq worker (redis 5.0.1, rq 1.15.1)

@ghalimi if you can provide a Redis Cluster that I can use to test, I can try to debug this issue sometime in the next few days.

Use RedisCluster as connection argument for rq worker (redis 5.0.1, rq 1.15.1)

Ah, in this case if Redis cluster is used, you can't use `queue.lmove`. You should fallback to `queue.lpop()` https://github.com/rq/rq/blob/2f5fecc1badb75b3e379b5d15c0b60b9c4931baa/rq/queue.py#L1364

Group jobs into batches and retrieve by batch name

Once we finalize what approach we want to take, we can also start merging this into master slowly, starting from the `Batch` class.

Group jobs into batches and retrieve by batch name

Will try to review this week

Group jobs into batches and retrieve by batch name

I’ll try to take a look soon. Sorry, my schedule recently has been packed.On Aug 4, 2023, at 7:46 PM, Ethan Wolinsky ***@***.***> wrote: @selwin Any chance I could get...

Group jobs into batches and retrieve by batch name

Please resolve the conflicts also :)

Group jobs into batches and retrieve by batch name

@eswolinsky3241 will try to review sometime in the next few days. Feel free to ping me again if I haven't done so in a week.

Group jobs into batches and retrieve by batch name

Sorry for the late review, hopefully this will be the last revision. Thanks for the effort!

Group jobs into batches and retrieve by batch name

Will do in a few days. Sorry for the delay 🙏🏻

Group jobs into batches and retrieve by batch name

Friendly reminder to look at the last batch of comments @eswolinsky3241 :). Ideally we can get this into the next 2.x release.