Selwin Ong

Results 509 comments of Selwin Ong

I'm re-running CI, once all the tests pass, I'll merge this PR in.

Hi Matthew, The final decision is of course yours but let me try to convince you why I think my proposed behavior makes sense ;) So I believe there are...

Upon checking the code, this logic is already here. https://github.com/rq/rq/blob/840438559261fd64b07d1bce489d352e6d553da5/rq/job.py#L803

Hey sorry I totally missed this update to your PR. This looks good, thanks!

Now I'm just re-running all the tests and if they pass, I can merge this in.

@poitch can you try to reproduce this locally and send a few stack traces? Also, does Django RQ's test suite runs on your local development environment?

This issue may be related to https://github.com/rq/django-rq/issues/375 @poitch @Ebrahimhammad . Have you tried changing the worker class to `SimpleWorker` (does not call `os.fork()`) and see if it works?

@matibarriento I'm ok with transitioning this to jazzband, but what's the next step?

> Heartbeat runs hset right after a expire command, but doesn't check if the command was already expired, this may be a challenge if it's running within a pipeline, since...

I'm mostly ok with using black. Now the only thing left for me would be to integrate black into my RQ development workflow :)