Selwin Ong

Results 509 comments of Selwin Ong

@karlcow thanks for the offer :). Let's hope that https://github.com/tobie/ua-parser/pull/331 gets merged soon.

Do you mind fixing the merge conflict so I can merge this in?

What kind of classification would you apply to a Facebook app though? The only thing I can think of is to make `is_bot=True` for this user agent.

I wonder if we should just hardcode the three tablet model numbers found on tera-wurfl.com: http://www.tera-wurfl.com/explore/search.php?search=samsung+sch&mode=all&action=search&submit=Search+Devices . Alternatively, we could also drop the check altogether as future tablet devices shouldn't...

Thanks for the report. Does Firefox also have a version for tablet devices? I just want to make sure that we can properly differentiate between tablet and mobile Firefoxes.

Never mind my question. I saw this issue before #6

I'm also running into this issue. I keep getting redirected to login page when using Graph 2.2 :(

Thanks, can you make sure that all tests pass so I can merge this in?

@lowercase00 this looks good, do you mind fixing the merge conflict so I can merge this in? Additionally I'm also wondering whether we can setup CI such that additional codes...