Selwin Ong comments

Results 507 comments of


                                            Selwin Ong

trafficstars

Bug Fix: Fix NOAUTH when using Sentinel with Password

I think it would be better if the user can explicitly specify auth credentials to sentinels.

Document REDIS_CLIENT_KWARGS

Do you mind opening a PR for this?

django-rq not showing up in admin sidebar

Mind opening a PR for this?

persistent database connections?

Not at the moment, Django-RQ explicitly closes all DB connections prior to calling `os.fork()` and executing jobs. Suggestions on how we can make this more efficient is welcome.

Each queue should be able to have its custom_exception or None.

I agree that this is a good idea. However, I'd like to keep it backwards compatible if we can. Could you please change your PR to make `exception_handlers` fallback to...

Each queue should be able to have its custom_exception or None.

@fchevitarese could you also fix the failing tests?

Add the possibility to set JOB_CLASS in get_scheduler call

PR welcome!

Failed job column in rqstats command

Because it's not implemented in RQ itself. If you're willing to help, please open a PR for this in RQ's repo https://github.com/rq/rq

Failed job column in rqstats command

Upon further investigations, `rqstats` is a management command dprovided by Django-RQ so it should be fixed here. The reason failed jobs are not showing is probably because RQ > 1.x...

Use a transaction when enqueuing a job to ensure atomicity

Sorry for the late reply, I'd like to get this merged in if you could just address my comment here: https://github.com/rq/rq-scheduler/pull/223#discussion_r414228561