django-rq icon indicating copy to clipboard operation
django-rq copied to clipboard

Published 20 hours ago • verified publisher icon rq

Bug Fix: Fix NOAUTH when using Sentinel with Password

Open neil-pozetroninc opened this issue 6 years ago • 3 comments

Currently when using Sentinel the password from the config is not passed through to the Sentinel class which results in a NOAUTH when connecting.

This patch passes through the same PASSWORD from the config through to both the Sentinel and the Master. This may not be what you want but it will solve the problem if both passwords are the same.

neil-pozetroninc avatar Jun 24 '19 05:06 neil-pozetroninc

Could you please fix the test errors so I can merge this in?

selwin avatar Jun 24 '19 23:06 selwin

I can, but is this the approach you want to take? There are several ways to address this bug, for example you may want another config value for the SENTINEL password instead.

Please let me know if this is your preferred approach.

neil-pozetroninc avatar Jun 25 '19 04:06 neil-pozetroninc

I think it would be better if the user can explicitly specify auth credentials to sentinels.

selwin avatar Jul 05 '19 03:07 selwin