Samuel Giddins

Results 281 comments of Samuel Giddins

https://github.com/rubygems/rubygems/blob/3fdc2f627e6bb476b722c7d37b61074430dea82e/lib/rubygems/package/tar_header.rb#L136 should make it a trivial thing to support

I'm not sure why bundler would exit non-zero if the setting isn't set -- nothing has "failed" when invoking that command, since _all_ settings are allowed to be nil

> If a setting is explicitly set to nil, then it wouldn't be an error because the setting exists and is set with a value. That's a meaningfully different condition...

That would be a great improvement, I'd be happy to review a PR if you're able to pull one together!

Should we add a test for what happens if the missing dependency causes a conflict with an existing gem in the lock file? Also if the missing dependency has dependencies...

> MD5. This would mean fixing compact_index_client/cache.rb to build checksums with a new algorithm when the updater finds that it's able to fetch info_checksums I dont think this would work,...

Ah i have things backwards. The etag is opaque, but we use the info checksum to compare against what's on disk, and the info checksum isnt necessarily the etag

Does https://github.com/aasm/aasm/pull/873 fix things for y'all?

How much merging does the yarn feature do? Does it only handle unrelated conflicts? How should we deal with the same gem changing to two different versions?

Just copy/pasting this from `gem help install` (not saying the way it is now is ideal): ``` --clear-sources Clear the gem sources -s, --source URL Append URL to list of...