Sheridan C Rawlins
Sheridan C Rawlins
Yep thanks for the pings and sorry I didn't get to closing. By adding all keys only in entrypoint hooks we avoid all contention later. Will try to document when...
I can see that there's already a private class that implements this and a public function NewTickerTaskFromFunc, so this particular PR is not very useful; closing
> Hi @scr-oath, can you please merge with master and resolve conflicts? Thanks! DONE
FWIW, marking draft - we're fighting with some mobile SDK crashes related to the piece that adds the full-request timeout stuff… essentially, SDK crashes if the passthrough exists and we...
We discussed this a fair bit in the Prebid Server backlog review and it seems there are other concerns/needs that may need some thought/discussion. 1. Tmax should be used as...
## Comprehensive Review: Logger Abstraction Phase 1 I've reviewed PR #4085 with golang-pro, code-reviewer, and refactoring-specialist perspectives. Here's the synthesis: ### 🎯 Executive Summary This phase 1 logger abstraction is...
FYI - the previous comment was from 🤖 Claude - I had prompted with a preference to stay with Errorf for the glog since all other major logging solutions (including...
## Review Summary This PR delivers a significant **5-10x performance improvement** (5-10s → 500-600ms) for GDPR vendor list preloading. The implementation using `golang.org/x/sync/errgroup` is generally sound, but requires critical production...
## 🔴 CRITICAL: Missing panic recovery (gdpr/vendorlist-fetching.go:92-109) If `saveOne()` panics (e.g., from malformed JSON), the entire server crashes. Add panic recovery to all goroutines: ```go wgLatestVersion.Go(func() error { defer func()...