Sheridan C Rawlins

Results 68 comments of Sheridan C Rawlins
trafficstars

Artifactory can have read through caches (easier than full-fledged mirror) so if asdf could have some config file that altered the URL, that could be enough

Just merged and resolved the conflict in `go.sum` via `go mod tidy`… Any chance someone can review and merge this?

> I think you can probably just set the tls client config all the time (I know I do this in my own code, though I always use tls), the...

> You have the clumsiness of an extra if, but you do the assignment only once (for me, doing the assignment up to 3 times is less readable, though admittedly...

Why not use testify - you're already bringing it in https://github.com/hashicorp/terraform/blob/main/go.sum#L605 it's much more readable and has IDE support - you can you see diffs, etc in the format of...

> Thanks for making the requested changes. The testify library appears in go.sum because it is used by one of Terraform Core's dependencies, but it is not used in the...

> Please also rebase your branch against `main`. Done - rebased and force pushed - now all changes appear directly from the merge-base (no merges)

Yeah, I came to the same conclusion about the intended usage, but you can't even read safely because if two bidders run in parallel and each return new contexts, those...

Yeah I'll look into that. We found a workaround that I may just document instead. We register an entrypoint hook where we return the ModuleContext with one key with a...

Oh and I should point out that groups run different modules in parallel - each gets their own context and… bidder-related hooks run _The Same_ hook (with same context) in...