Scott Rippey comments

Results 115 comments of


                                            Scott Rippey

Typescript returns an error due to `datum` not being in `CoordinatesPropType`

Our type definition for this prop was incorrect, and has been fixed in #2419 👍 Thanks for finding this!

Typescript returns an error due to `datum` not being in `CoordinatesPropType`

Fixed in `36.6.1` 👍

error after running yarn lint

This has been fixed in the latest version. Thanks for reporting!

[WIP] Turbo: Property Containers

The CI failures are due to newly-added exports, but this will be fixed by #2431

Webpack warns about not finding source map files

I am currently investigating, and working on a fix. Thank you for reporting!

Webpack warns about not finding source map files

Fixed in `36.6.3`, thanks for reporting!

Failed to parse source map from '[...]/node_modules/victory-core/es/victory-util/hooks/index.js.map' file: Error: ENOENT: no such file or directory, open '[...]/node_modules/victory-core/es/victory-util/hooks/index.js.map'

Thanks for posting this issue, I just started investigation!

Failed to parse source map from '[...]/node_modules/victory-core/es/victory-util/hooks/index.js.map' file: Error: ENOENT: no such file or directory, open '[...]/node_modules/victory-core/es/victory-util/hooks/index.js.map'

I'm going to close this as a duplicate of #2346 -- please track all progress there

Ts build fail TS1110: Type expected.

TypeScript 4.1 introduced these [Template Literal Types](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html) ... so this issue appears to be due to the older TypeScript version being used. That being said, I'll investigate how often we...

Ts build fail TS1110: Type expected.

@gksander We currently use "Template Literal Types" syntax in 2 places: [ComponentEventName] and [SafeAttribute]. Neither is too critical, and only provides a tiny-bit of type safety, so what do you...