victory icon indicating copy to clipboard operation
victory copied to clipboard

error after running yarn lint

Open 3KINGZ opened this issue 3 years ago • 1 comments

Describe the bug am getting an error when running yarn lint export { Border as Box, type BorderProps as BoxProps, } from "./victory-primitives";

Victory version ^36.5.3

Code Sandbox link Please include a code sandbox link or a similar reproduction if possible.

To Reproduce Steps to reproduce the behavior: 1.yarn lint

Expected behavior export { Border as Box, type BorderProps as BoxProps, } from "./victory-primitives";

Desktop (please complete the following information):

  • android/ios

3KINGZ avatar Jun 28 '22 06:06 3KINGZ

Just for anyone else who might come across this, I'm seeing this cause a build failure on TypeScript version 4.3.5. I'm assuming that it's related to the type keyword used in the export statement, which might not be supported until a later version of TypeScript

This is the error I'm seeing:

ERROR in node_modules/victory-core/lib/index.d.ts:15:30
TS1005: ',' expected.
    13 | export * from "./victory-portal/victory-portal";
    14 | export * from "./victory-primitives";
  > 15 | export { Border as Box, type BorderProps as BoxProps, } from "./victory-primitives";
       |                              ^^^^^^^^^^^
    16 | export * from "./victory-util";
    17 | export * from "./victory-state";
    18 | //# sourceMappingURL=index.d.ts.map

chrisbutler avatar Jun 30 '22 20:06 chrisbutler

This has been fixed in the latest version. Thanks for reporting!

scottrippey avatar Aug 19 '22 03:08 scottrippey