Martin Schenck

Results 104 comments of Martin Schenck
trafficstars

I get the same for `ndb ./node_modules/.bin/react-scripts start`

@tknickman you want an empty array as second argument to `useEffect` in `FullScreen` in order to only execute it once.

@tknickman turns out you *also* want `process.stdout.write(enterAltScreenCommand);` to be inside the `useEffect` so that *that* is only called once. 😉

Did arc make a new release? Did they bump major or minor version? Basically, we are not making any changes on our end, only pulling upstream. Right?

I would say that, generally, just pulling upstream would be a patch release. If we make changes on our end, it could be a major, minor, or patch change. However,...

From https://github.com/arc-design/arc-theme/releases/tag/20190917 I would say it’s a minor version. But I think you know more and can better judge.

Maybe. The way SolArc works is that it simply replaces colors. Check out `solarize.sh` to see what it does. The problem with changing *that* color is that it possibly breaks...

Hmm, I see. Thanks. Can you get the color codes for Arc and SolArc tooltip background and foreground and compare them with what we have in `solarize.sh`? The thing is...

Thank you for taking the time and figuring this out! What I meant was: would it be possible for you to clone this repository, change the relevant variables in `solarize.sh`...

OK :ok_hand: Just let me know.