Sam Clegg

Results 1115 comments of Sam Clegg

So it looks like the issue is with the order of the native port libraries on the command line. Firstly, we should fix that so that its determinisitic. Secondly, you...

You could confirm by doing something like `-Wl,--trace-symbol=deflate` to see if the definition of this symbol comes from a different library in the two cases.

OK, thanks for debugging that! Sounds like have two different bugs here: 1. Port linking order is non-deterministic 2. libfreetype embed its own zlib instead of using the emscripten port....

yes, the non-determinism was fixed. Now we just need to fix the duplication part I think.

Yes, that is correct. That is why think it might be better fix the duplication issue, since honoring the command line order doesn't look easy. And we should fix the...

(We should probably sort the directory listing to really get determinism... but that still wouldn't fix the duplication issue)

Fix should be in https://github.com/emscripten-core/emscripten/pull/22062

Can you confirm this is fixed now that #22062 has landed?

I have a WIP PR convert GL to using the handle allocator: https://github.com/emscripten-core/emscripten/pull/18874. I think that would solve the problem here.