Sam Clegg
Sam Clegg
Well updating wasmtime to unconditionally accept LEB encoding for this immediate certainly seems like the simplest solution then. Currently both wabt and wamr gate the encoding change on reftypes being...
I doubt we would ever consider turning on a feature by default in LLVM before it was fully merged in the main spec repo. I think we can expect a...
> Doesn't the linker already support mixing object files without relocations for `call_indirect` and those with them? > > In other words, what would be the cost of hard-coding the...
> Given that the latest release was 8 years ago and the main maintainer has no public activity last 3 years, it will take a long time to land the...
Seems like a worthwhile effort. Sounds like we could start by making the inclusion of `math.h` and `alloca.h` conditional? Would you like send a PR for that? Is there some...
The fact that flake8 is being included at all in CI makes me think that perhaps you are not up-to-date on your branch? The flake8 step was replaced with a...
Can you try rebase onto to merging with the latest changes on main?
> > Any updates or blockers here? I'd like to see this land as well, we're also using workers that need to sync await some main thread code. > >...
Thanks for continuing to work on this. Apologies for the review process taking so long. I had no imagined this being such an invasive change (i.e.changing the code proxying functions).
It looks like closure does't like this: ``` building:ERROR: /tmp/emscripten_temp_qawuf4_3/test.jso4.js:356:29: WARNING - [JSC_INEXISTENT_PROPERTY] Property nextWorkerID never defined on PThread 356| "name":"em-pthread-"+PThread.nextWorkerID};var pthreadMainJs=_scriptName;// We can't use makeModuleReceiveWithVar here since we want...