Sam Clegg

Results 1250 comments of Sam Clegg

> Anything I can do, to help move this forward? IIUC this seems like a good change but we are waiting a test case.

> It's perfectly legitimate to return a promise instead, and sometimes that would result in cleaner code. This should be at most a warning, not a requirement. Right, but there...

> I guess.. though I think it would be slightly lower performance (probably not noticeable unless it's a really hot function.) According to AI there is not any extra overhead:...

I don't see any way in which the `Cannot set timing mode for main loop since a main loop does not exist` warning could ever be an error so I...

I reopened https://github.com/emscripten-core/emscripten/issues/7100 so we can address that error spam

This is certainly a bug, but its a complicated area. The conditions underwhich we allow node to exit, or indeed the runtime to exit, are one of the most complex...

The code that allows node to exit with running threads is here: https://github.com/emscripten-core/emscripten/blob/80ca182d92aa33f874acd2f25718143ce8848f37/src/lib/libpthread.js#L275-L283

Another way of putting it: In the OP code the emscripten runtime is kept alive (i.e. we never call exitRuntime()), but there is nothing to keep the node process alive....

As I said in my original reply, This is certainly a bug, but its a complicated area. We can, and maybe should invest more in making node work more like...