sander2

Results 53 comments of sander2
trafficstars

I'm in favor of removing, but I'd note that on Kintsugi we've had 13 refund requests, all of which have been executed. Did @nud3l sign off on this change? Edit:...

> @sander2 do you think we should explicitly clear storage (for refund) in the migration? We could, yea, or we can manually do a kill_prefix together with the 1.20 upgrade

> I still need to investigate the consequences of this change So should we hold off on merging this until you do?

Changed milestone to 1.20 since you mention there is some work to do still and it's a low prio pr

I looked some more into this. It turns out that the `author_extrinsicUpdate` _always_ is fired with `"result":"ready"` and `"result":{"inBlock`, but `"result":{"finalized"` is fired only sometimes. I ruled out a client-side...

I have done some re-testing and found that this is still not fixed in 0.9.24. I believe that the root cause of this issue is one of notification ordering. The...

Thank you @bkchr . I tried to implement your suggestion but unfortunately, being unfamiliar with the codebase, I did not succeed. I wanted to try to call `maintain(ChainEvent::NewBestBlock{...})` in the...

> LGTM > > Just one question: Are we okay with all constructed markets pointing to kusama/kintsugi related currencies like KSM, KBTC, and KINT even if this is called with...

How is this supposed to work on the client side? The client should automatically pick up the new vault, but the bitcoin will stay in the old wallet, so there...

This happens when a user is sending insufficient fees - the BuyExecution instruction fails and execution is aborted without depositing the already-withdrawn tokens. The same behavior is happening on Kusama...