sander2

I just realized that by doing the premium redeem, the collateral decreases. I didn't account for that in the premium cap calculation - should I? That's going to complicate the...

I just realized that this needs changes: - the to-be-issued tokens are likely incorrectly updated - this can put the vault below secure (or even liquidation) thresholds and can thus...

> I just realized that this needs changes: > > * the to-be-issued tokens are likely incorrectly updated > > * this can put the vault below secure (or even...

In the `service.rs` file we are checking `parachain_config.chain_spec.id() == "kusama"` and `x.spec_name.starts_with("kintsugi")`. Will they need to change as well?

As I mentioned in https://github.com/interlay/interbtc/pull/534, I'm a bit afraid of unforeseen consequences.. Can we test this before merging?

> . This will prevent re-use of it's AccountId and identity if an attacker would compromise the associated key file. They could just register anew, right? Unless you explicitly want...

Can you add some context please. What does this do and why do we need it?

> Before we merge this, we should consider the following proxy types (requested): > > * claiming rewards > > * transfers > > * issues / redeems This seems...

> Do we have to decide in advance which pallets we support for proxy? If we can decide now, that'd be ideal. Of course, we can always do a runtime...

Any chance you can split up your pr in at least 2 separate commits - one where you just add unchanged forked pallet, and one with the changes you made...