Adrian Sampson

Results 1026 comments of Adrian Sampson
trafficstars

That's a great analysis, @out-of-range. This is quite convincing, and those "compound IDs" you're generating like `album-42-cover.jpg` seem like an elegant solution to the problem with very few downsides to...

Yes, this is a great point. It does seem like we need _some_ way to do basic search—it will be hard to build useful interfaces on top of the API...

Sure; that seems cool! We could even consider keeping the `filter` namespace constant and just adding "qualifiers" to the field names to get different behavior, i.e., `?filter[artist]=Blue` for exact matches...

One option might be to have two separate options: a standard query interface using `filter[title]=...`, etc., that essentially encode SQL "WHERE" clauses, and a separate `search` that is much fuzzier—it...

Good question—sorry if I've lost track and the answer should be obvious, but what would we change them to? Are other tags in use by other software already?

Got it; I see what you're saying. It would indeed be a little tricky to get right in a backwards-compatible way… and the data (at least for beets) does literally...

Thank you for the thorough investigation. This is definitely a bug. The problem is here, in `MP3DescStorageStyle`: https://github.com/beetbox/mediafile/blob/edc64145e9e96624f8a77fd3cb929891c946d4dc/mediafile.py#L905-L909 Namely, when storing data into an ID3 `TXXX` field, which is disambiguated...

Again, thanks for getting this started! Let's tread carefully with respect to the case sensitivity thing. I note that you've created a capital and lower-case `StorageStyle` for each field. But...

Yeah, that's the idea—the loop you see in `MP3DescStorageStyle.store` tries to find an existing frame to store the data rather than blowing away the old one and creating a new...

> and upon _writing_, detect that it has no uppercase StorageStyle, so remove the existing uppercase tag and replace it with the variant from the StorageStyle (lowercase). Hmm; I don't...