Adrian Sampson

Results 1031 comments of Adrian Sampson
trafficstars

Aha; nice catch! This actually has nothing to do with your Docker setup; it's a dependency version thing. The root cause is a new feature in the latest version of...

Good question---I worry a little that pinning dependency versions for (e.g.) CI will just move the problem somewhere else, when a *dependent* project notices breakage. (Because of the way Python...

Sounds pretty reasonable to me, despite my general resistance to additional configuration options. Because Mutagen has first-class support, I can see this being effective. Here are a few miscellaneous comments:...

That’s troubling. Making it a config option would actually be pretty disappointing—a nice thing about MediaFile as it currently stands is that it basically works, most of the time, for...

Something like this! I guess it would be useful to think through the right policy and what each option’s positives and negatives are. We can code up any policy we...

That seems like a good idea. For exceptions, this seems straightforward. For other (non-failure) cases, would we just check "round-trip" preservation of data?

Interesting point. If we do allow multi-valued options, it would be good to come up with some principled way of deciding this (rather than choosing per-field). For example, one easy-to-follow...

Yes, absolutely—there's a benefit to avoiding code that needs to check the type of the value. Taking that to the extreme, we could consider making _every_ field a list—which seems...

Points well taken about not going overboard with list-valued fields. If we do choose "string array" (JSON parlance) as the type for some fields, we should (a) think very carefully...

@ZenithDK, does a list-valued artist field resolve your question? Or were you getting at something else with the Three Tenors example (i.e., there are multiple ways to "say" the same...