Adrian Sampson

Results 1057 comments of Adrian Sampson

I'm all for it. Our current path handling stuff is too fiddly. I have one important concern: encodings. The core problem is that Unix paths need to be bytes and...

Yes, surrogate escaping is probably now the Pythonic way of doing this. A few thoughts/questions: - How hard will it be to be to make pathlib use surrogate escaping on...

OK, this migration plan sounds good. On Windows exceptions: Yes, if the OS can be trusted to always supply Unicode, then we should be OK. Hopefully, paths do not come...

Agreed; while pathlib will definitely be nice, it will not solve our encoding and sanitation problems. Those will still be 100% up to us.

Hi! Thanks for being interested in taking this on! I think the big obstacle here is about Unicode, surrogate escapes, and SQLite storage. Namely, because surrogate escapes are a Python-specific...

> Does this seem reasonable? > > Note, it is possible to call `str(path)` for all windows paths and `bytes(path)` for all unix paths for storing in the database. I'm...

Certainly no objection! One thing I'm a little mystified by in this department is how to prioritize. We probably don't want to do it all at once, so we'd need...

Very true. Perhaps starting with `dbcore` would be a useful way in? It's kind of at the bottom of everything, touches all other modules (at least indirectly), and is meant...

Sure! Yeah, it's definitely possible that something's wrong, or that the typing is just kind of subtle and will require some thought to annotate correctly. Maybe a good way to...

Huh, you're absolutely right! Not sure how that default slipped in there: https://github.com/beetbox/beets/blob/50bd693057de472470ab5175fae0cdb5b75811c6/beetsplug/convert.py#L139