Sagilio

Results 38 comments of Sagilio

@tangyang9464 @hsluoyz Do we have any existing tests to see the rate of performance degradation because of this PR? I think if we check the length in any edit policy...

@hsluoyz I see, but the changes in this PR don't seem to be covered by any of the tests in `xxx_b_test.go`, and the benchmark result in each CI run may...

@hsluoyz The reason for the deviation of each ci test is that the environment(CPU) is not fixed. There is only a little difference between the same environments. Casbin.NET's result will...

According to the principle of expression, this is a valid operation to improve performance. I think we can add this to the docs. It sounds good If we can auto...

@abichinger @tangyang9464 I think we only need to remove the cache of compiled function when the existing function is changed,

@tangyang9464 Priority and allow/deny-override effect expression are combinable, here is a similar issue: https://github.com/casbin/Casbin.NET/issues/188 More like the concept of dividing different policies set by priority.

@hsluoyz Yes, they have the same style.

The release of `Casbin.Adapter.EFCore` and `Casbin.AspNetCore` is only work for Casbin.NET v1. I will release 2.x versions of them that are compatible with the Casbin.NET v2 this year.

@krishnaanaril Of course! Welcome to open issues or pull requests.

> So, how far along are we? where can I help? Thanks! Most features have been merged, but we have some other work: 1. An known load policy bug (https://github.com/casbin/Casbin.NET/issues/183)...