Sagiv ben giat

Results 54 comments of Sagiv ben giat

> Please upvote the PR by giving a 👍 on it .. @dargmuesli Which PR is addressing this issue?

Yeah i don't think this issue is getting the attention it deserves. I tried to reproduce it with a "clean" project but i couldn't. It only happens when i migrate...

Update - After some more playing around, i found out that it happens only when i enable some of my stories, meaning that when i only include some stories from...

Everything sounds great though i do have a major concern (or a question) here. Lets say i have a Design System library that wraps MUI, we don't have a build...

Interesting idea indeed. Thanks

@nicgirault Greate article. The part of providing the immutable `location` to the `switch` made me smile :smile: I'm going to explore your example's source code, it looks great! Thank you.

Did you all try to make the bash script as an executable? 1. Adding a [shebang](https://en.wikipedia.org/wiki/Shebang_%28Unix%29) `#!/bin/bash` at the top of the file. 2. Changing permissions: `chmod +x myScript.sh`

A callback has a lot of use cases indeed. I would say any animation library should expose a life cycle methods eg: `before-animation` `after-animation` etc.. but a callback for a...

@flyingant I've noticed that `react-scroll-to-component` uses `scroll-to` behind the scenes. `scroll-to` uses `tween.js`, and i came across [this comment](https://github.com/component/scroll-to/issues/1#issuecomment-358056653). So i guess this is "doable" 😃 All we need to...

this is coming from [here](https://github.com/flyingant/react-scroll-to-component/blob/5e9359d38bef3b4cc524a9f3bab4585db4a5cc59/index.js#L29) i think. So if you call `scrollToComponent` inside your `render` you will get this warning.