Philipp Korber

Passwords are not cleard securly enough.

3

You need to use `write_volatile` instead of `write_bytes` or the clearing might be optimized away. E.g. if you take a look at how the C argon library uses password clearing...

All multiplexing futures are potentially broken by tokios preemting-cooperative feature.

4

This is not limited to `FuturesUnordered`. TL;DR: Tokio futures subtle brakes not just `FuturesUnordered`, but also `join_all`, various `joinX` and maybe other combinators. Relate: #2387 , # The new feature...

Listing all "features"

6

I think it would be a nice think to have a list of all features with a one sentence description and a link to a part of the tutorial explaining...

The llsc stack is not safe from ABA with how LL/SC is used

10

> On the Cortex-M, STREX will always fail if the processor takes an exception between it and its corresponding LDREX operation But the load of `next` at `8000136` is done...

Using clippy got harder with the explicit target_features `atomics` check.

6

https://github.com/GoogleChromeLabs/wasm-bindgen-rayon/blob/4cd0666d2089886d6e8731de2371e7210f848c5d/src/lib.rs#L14-L15 This line causes clippy to fail if you didn't set the appropriate compiler flags *and* used the right `--target` arguments. Commenting out the lines prevents this failure as it...

inspect.getargspec incompatible with kwonlyargs and function annotations

2

If `inspect.getargspec` function is used to inspect a function with with kwonlyargs or function annotations a `ValueError` is raised. In python3 a `inspect.getfullargspec` function exists witch could be used as...

Bugs in the resources (qrc) example

6

Hy, TL;TR: see bold text ;) ther are a **number of Bugs in the resource example**: 1. the `sh build_lib.sh` command is run in the repos root, not the `resource`...

Kosovo was missing from the country codes list. - [ ] Is it properly supported in other parts? - [ ] Are other country codes absent?

Make sure there are no unessesary panics.

1

- [ ] go though all unwrap usages - [ ] make sure error handling is documented appropriately

- There was a now out of sync PR https://github.com/rustonaut/rust-phonenumber/pull/5 - There was a local implementation which might or might not have merged. - There might or might not be...